> > +/* gdbstub.c */ > > +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *ppc); > > +gchar *ppc_gdb_arch_name(CPUState *cs); > > These should probably go into internal.h and not cpu.h. > These do not need to be exposed outside of target/ppc/.
Makes sense, I can do that. Is such a small change worth a v3, or do I fix this as I send the disable-tcg patch series? > > +#include "exec/helper-proto.h" > > Not ideal, but ok temporarily. yeah, this is only here until we figure out how to deal with the vscr stuff. > > + gdb_get_reg32(buf, helper_mfvscr(env)); > ... > > + helper_mtvscr(env, ldl_p(mem_buf)); > > These should be modeled on e.g. store_fpscr, where there's a non-"helper" > function to be called, which is then called by the "helper" function. > > Obviously, splitting that out should be a separate patch. We already expected to fix this in the disable-tcg patch series, but this reference does help (: However, checking now, store_fpscr is defined in fpu_helper.c, which is mostly TCG stuff. Any idea where we could move the store_* functions to have them compile in the !tcg build? My best guess is to do it in cpu.c, as the other files compiled with the same options are cpu-models.c and gdbstub.c. Bruno Piazera Larsen Instituto de Pesquisas ELDORADO<http://clickemailmkt.eldorado.org.br/ls/click?upn=UPoxpeIcHnAcbUZyo7TTaswyiVb1TXP3jEbQqiiJKKGsxOn8hBEs5ZsMLQfXkKuKXZ7MVDg0ij9eG8HV4TXI75dBzDiNGLxQ8Xx5PzCVNt6TpGrzBbU-2Biu0o69X5ce-2FW-2FOk1uUipuK0fZnWXJEgbRw-3D-3DJY4T_wWk-2BG6VvNBoa1YzxYjhCdFS9IfANIaBzDSklR1NyyrKOI1wj0P-2BdBFcuO4FnHcsA1MyHu0ly1Yt3oDMp7KKdJPM68iKuI2jiRH5v4B0d8wf3chU3qy5n5iXWnW1QjSaNFHOgELzxaP-2FnesTeBgJ5dFkjH4f279sVQpOtyjw5xAqj34M6pgNRAxVvuXif4IWDcVzXg1FzfYlEfkKzr9vvpA3Hg8kitwMtlU3zwbQUBCgL30fQoJPcRPMGKyOY8RmoAlXNqTJYDYIvqmfnI7KLUvw6vKB5R-2B5q1FJRAzX7H-2BmF0NnDET6jMLuIqtCcVIch> Departamento Computação Embarcada Analista de Software Trainee Aviso Legal - Disclaimer<https://www.eldorado.org.br/disclaimer.html> ________________________________
