On 09/26/2011 01:08 PM, Avi Kivity wrote:
On 09/25/2011 08:31 PM, Blue Swirl wrote:
>
>  Please point out a test case and I'll try to fix it.

Run qemu-system-ppc without any arguments. There is a black bar
(because of vga.chain4), it shouldn't be there.

With your pci hole patch, it's fixed, except for:

    escc_mem = escc_init(0x80013000, pic[0x25], pic[0x24],
                         serial_hds[0], serial_hds[1], ESCC_CLOCK, 4)

This puts escc bang into the framebuffer. Changing it to 0x90013000 makes the black bar go away.

Before the memory API, this worked, likely because the framebuffer overlays escc.

The correct fix depends on what the hardware does. Is escc really registered into the pci area, and again as a BAR?


If we reenable the collision warning in memory.c, we see

warning: subregion collision 80013000/40 (escc) vs 80000000/70000000 (pci-hole)

I'll work on reenabling ir permanently.

--
error compiling committee.c: too many arguments to function


Reply via email to