On 4/20/21 2:20 PM, Alex Bennée wrote: > David Gibson <da...@gibson.dropbear.id.au> writes: >> On Mon, Apr 19, 2021 at 10:33:07PM -0300, matheus.fe...@eldorado.org.br >> wrote: >>> From: Matheus Ferst <matheus.fe...@eldorado.org.br> >>> >>> A newer compiler is needed to build tests for Power10 instructions. As >>> done for arm64 on c729a99d2701, a new '-test-cross' image is created for >>> ppc64 and ppc64le. As done on 936fda4d771f, a test for compiler support >>> is added to verify that the toolchain in use has '-mpower10'. >>> >>> Signed-off-by: Matheus Ferst <matheus.fe...@eldorado.org.br> >>> --- >>> tests/docker/Makefile.include | 2 ++ >>> .../debian-powerpc-test-cross.docker | 17 +++++++++++++++++ >>> tests/tcg/configure.sh | 12 ++++++++---- >>> 3 files changed, 27 insertions(+), 4 deletions(-) >>> create mode 100644 >>> tests/docker/dockerfiles/debian-powerpc-test-cross.docker >>> >>> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include >>> index 9f464cb92c..f1dbcc639f 100644 >>> --- a/tests/docker/Makefile.include >>> +++ b/tests/docker/Makefile.include >>> @@ -152,10 +152,12 @@ docker-image-debian-sparc64-cross: >>> docker-image-debian10 >>> docker-image-debian-tricore-cross: docker-image-debian10 >>> docker-image-debian-all-test-cross: docker-image-debian10 >>> docker-image-debian-arm64-test-cross: docker-image-debian11 >>> +docker-image-debian-power-test-cross: docker-image-debian11 >>> >>> # These images may be good enough for building tests but not for test >>> builds >>> DOCKER_PARTIAL_IMAGES += debian-alpha-cross >>> DOCKER_PARTIAL_IMAGES += debian-arm64-test-cross >>> +DOCKER_PARTIAL_IMAGES += debian-power-test-cross >> >> You add these "power" (as opposed to "powerpc" or "ppc64" or whatever) >> images here, but they don't seem to be referenced anywhere else. >> >>> DOCKER_PARTIAL_IMAGES += debian-hppa-cross >>> DOCKER_PARTIAL_IMAGES += debian-m68k-cross debian-mips64-cross >>> DOCKER_PARTIAL_IMAGES += debian-powerpc-cross debian-ppc64-cross > > I was expecting the new debian-power-test-cross to replace both > debian-powerpc-cross and debian-ppc64-cross.
Maybe rename the images as: DISTRIB-TARGET-crossbuild and DISTRIB-TARGET-crosstest-tcg? (as it is not obvious for every contributor than 'cross' imply emulation and not virtualization).