Re: [PATCH 4/5] target/mips: Use check_cp0_enabled() returned value

[Richard Henderson]

On 4/20/21 12:34 PM, Philippe Mathieu-Daudé wrote:

@@ -14809,14 +14811,15 @@ static void gen_pool32axf(CPUMIPSState *env, 
DisasContext *ctx, int rt, int rs)
          }
          break;
      case 0x05:
+        if (!check_cp0_enabled(ctx)) {
+            break;
+        }
          switch (minor) {
          case RDPGPR:
-            check_cp0_enabled(ctx);
              check_insn(ctx, ISA_MIPS_R2);
              gen_load_srsgpr(rs, rt);
              break;
          case WRPGPR:
-            check_cp0_enabled(ctx);
              check_insn(ctx, ISA_MIPS_R2);
              gen_store_srsgpr(rs, rt);
              break;

cp0 check before decode complete.  at least 2 more instances in this patch.


r~