On Mon, Apr 26, 2021 at 07:29:54PM +0000, Bruno Piazera Larsen wrote: > > > code motion to remove opcode callback table from > > > translate_init.c.inc to translate.c in preparation > > > to remove #include <translate_init.c.inc> from > > > translate.c > > > > I'd mention the creation of destroy_ppc_opcodes since this patch is not > > strictly just moving code. > > Sure, will do for v2. > > > > +#if defined(PPC_DUMP_CPU) > > > > The commented out define for this was left behind. > > Good catch! The define is going to still be used by a couple of things in > cpu_init, though. > I'm guessing moving to internal.h is the best solution, but correct > me if I'm wrong
Generally LGTM, excepting the things Fabiano pointed out. > > > Bruno Piazera Larsen > > Instituto de Pesquisas > ELDORADO<http://clickemailmkt.eldorado.org.br/ls/click?upn=UPoxpeIcHnAcbUZyo7TTaswyiVb1TXP3jEbQqiiJKKGsxOn8hBEs5ZsMLQfXkKuKXZ7MVDg0ij9eG8HV4TXI75dBzDiNGLxQ8Xx5PzCVNt6TpGrzBbU-2Biu0o69X5ce-2FW-2FOk1uUipuK0fZnWXJEgbRw-3D-3DJY4T_wWk-2BG6VvNBoa1YzxYjhCdFS9IfANIaBzDSklR1NyyrKOI1wj0P-2BdBFcuO4FnHcsA1MyHu0ly1Yt3oDMp7KKdJPM68iKuI2jiRH5v4B0d8wf3chU3qy5n5iXWnW1QjSaNFHOgELzxaP-2FnesTeBgJ5dFkjH4f279sVQpOtyjw5xAqj34M6pgNRAxVvuXif4IWDcVzXg1FzfYlEfkKzr9vvpA3Hg8kitwMtlU3zwbQUBCgL30fQoJPcRPMGKyOY8RmoAlXNqTJYDYIvqmfnI7KLUvw6vKB5R-2B5q1FJRAzX7H-2BmF0NnDET6jMLuIqtCcVIch> > > Departamento Computação Embarcada > > Analista de Software Trainee > > Aviso Legal - Disclaimer<https://www.eldorado.org.br/disclaimer.html> -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature