On 4/15/21 6:23 AM, Philippe Mathieu-Daudé wrote:
Hi,
The floppy disc controllers pulls in irrelevant devices (sysbus in
an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
This series clean that by extracting each device in its own file,
adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.
Regards,
Phil.
Lightly reviewed and I'm fine with it overall; but want a quick ~5min
up-or-down by Hervé and/or Mark (To make sure this doesn't break any
non-x86 system they may care about), and a quick nod from Paolo for
KConfig changes would be nice.
I'll be waiting on a reply to my question on patch 01 before staging.
--js
Philippe Mathieu-Daudé (4):
hw/block/fdc: Replace disabled fprintf() by trace event
hw/block/fdc: Declare shared prototypes in fdc-internal.h
hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c
hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c
hw/block/fdc-internal.h | 155 ++++++++++
hw/block/fdc-isa.c | 313 +++++++++++++++++++++
hw/block/fdc-sysbus.c | 252 +++++++++++++++++
hw/block/fdc.c | 608 +---------------------------------------
MAINTAINERS | 3 +
hw/block/Kconfig | 8 +
hw/block/meson.build | 2 +
hw/block/trace-events | 3 +
hw/i386/Kconfig | 2 +-
hw/isa/Kconfig | 6 +-
hw/mips/Kconfig | 2 +-
hw/sparc/Kconfig | 2 +-
hw/sparc64/Kconfig | 2 +-
13 files changed, 751 insertions(+), 607 deletions(-)
create mode 100644 hw/block/fdc-internal.h
create mode 100644 hw/block/fdc-isa.c
create mode 100644 hw/block/fdc-sysbus.c
