On Sun, Apr 25, 2021 at 02:21:38PM +0200, Maciej S. Szmigiero wrote: > On 11.10.2020 01:30, Maciej S. Szmigiero wrote: > > On 09.10.2020 23:33, Eduardo Habkost wrote: > > > On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote: > > > > On 09.10.2020 22:07, Eduardo Habkost wrote: > > > > > Having properties registered conditionally makes QOM type > > > > > introspection difficult. Instead of skipping registration of the > > > > > "instanceid" property, always register the property but validate > > > > > its value against the instance id required by the class. > > > > > > > > > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > > > > --- > > > > > Note: due to the lack of concrete vmbus-dev subclasses in the > > > > > QEMU tree, this patch couldn't be tested. > > > > > > > > Will test it tomorrow since I have a VMBus device implementation. > > > > > > Thanks! > > > > > > > Tested the patch with a hv-balloon device and is seems to work okay, so: > > Acked-by: Maciej S. Szmigiero <maciej.szmigi...@oracle.com> > > > > I see this patch wasn't picked up - it still makes sense and applies > cleanly to the current git, so I think it should be picked up.
I'm queueing it for 6.1, thanks for the reminder! -- Eduardo
