On Thu, Apr 29, 2021 at 11:59:41AM +0200, Markus Armbruster wrote: > Myself, but I only documented it; it's actually Kevin Wolf: > > ``blockdev-open-tray``, ``blockdev-close-tray`` argument ``device`` > (since 2.8.0) > > ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > Use argument ``id`` instead. > > ``eject`` argument ``device`` (since 2.8.0) > ''''''''''''''''''''''''''''''''''''''''''' > > Use argument ``id`` instead. > > ``blockdev-change-medium`` argument ``device`` (since 2.8.0) > '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > Use argument ``id`` instead. > > ``block_set_io_throttle`` argument ``device`` (since 2.8.0) > ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > Use argument ``id`` instead.
FYI, I did prepare patches for these already, but they broke the iotests. I found it difficult to figure out the right fix for the iotests, becuase IIUC "device" and "id" values are different, and I didn't see what "id" to use when args are still using -drive, not -blockdev. > Myself: > > ``blockdev-add`` empty string argument ``backing`` (since 2.10.0) > ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > Use argument value ``null`` instead. > > Myself, but I only documented it; it's actually Kevin Wolf: > > ``block-commit`` arguments ``base`` and ``top`` (since 3.1.0) > ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > Use arguments ``base-node`` and ``top-node`` instead. I've also got patches that remove these two, but didn't submit them as they were behind the patches for the "device" removal. > Block device options > '''''''''''''''''''' > > Myself: > > ``"backing": ""`` (since 2.12.0) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > In order to prevent QEMU from automatically opening an image's backing > chain, use ``"backing": null`` instead. Unless I'm mistaken, this appeared to end up being a dupe of the blockdev-add with empty string deprecation above. > Myself: > > ``rbd`` keyvalue pair encoded filenames: ``""`` (since 3.1.0) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Options for ``rbd`` should be specified according to its runtime options, > like other block drivers. Legacy parsing of keyvalue pair encoded > filenames is useful to open images with the old format for backing files; > These image files should be updated to use the current format. > > Example of legacy encoding:: > > json:{"file.driver":"rbd", "file.filename":"rbd:rbd/name"} > > The above, converted to the current supported format:: > > json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"} Got patch for this too All my unsubmitted patches related to block are here: https://gitlab.com/berrange/qemu/-/commits/dep-block NB I've not compile tested them recently since rebasing to git master. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|