Re: [PATCH v2 6/8] block: do not acquire AioContext in check_to_replace_node

[Paolo Bonzini]

On 19/04/21 10:55, Emanuele Giuseppe Esposito wrote:

+ *
+ * Called with AioContext lock held.

... for @to_replace_bs.

          aio_context_acquire(replace_aio_context);
+        if (!check_to_replace_node(bs, to_replace_bs, replaces, errp)) {

A release is missing here.

Paolo

+            return;
+        }
          replace_size = bdrv_getlength(to_replace_bs);