Hi Alex, On 4/19/21 5:11 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé <f4...@amsat.org> writes: > >> Extract the build/test jobs run by default on the mainstream >> CI into a new file (buildtest.yml) and their templates into >> (buildtest-template.yml), to be able to reuse the templates >> without having to run all these mainstream jobs by default. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> --- >> .gitlab-ci.d/buildtest-template.yml | 80 +++ >> .gitlab-ci.d/buildtest.yml | 744 +++++++++++++++++++++++++ >> .gitlab-ci.yml | 824 +--------------------------- >> 3 files changed, 825 insertions(+), 823 deletions(-) >> create mode 100644 .gitlab-ci.d/buildtest-template.yml >> create mode 100644 .gitlab-ci.d/buildtest.yml
> I don't know if my suggestion further bellow requires moving the above: > >> +build-system-alpine: >> +check-system-alpine: >> +acceptance-system-alpine: > > Maybe these can be moved into buildtest-rolling? Or maybe > buildtest-[unsupported|other]? As I temporarily can't test your suggestions, I'll send v2 without them, and will try to address them on v3 (I am not ignoring them). > <snip> > <snip> > >> +build-disabled: >> +build-tcg-disabled: > > to buildtest-custom? > > >> +build-user-plugins: >> +build-some-softmmu-plugins: >> +clang-system: >> +clang-user: >> +build-cfi-aarch64: >> +check-cfi-aarch64: >> +acceptance-cfi-aarch64: >> +build-cfi-ppc64-s390x: >> +check-cfi-ppc64-s390x: >> +acceptance-cfi-ppc64-s390x: >> +build-cfi-x86_64: >> +check-cfi-x86_64: >> +acceptance-cfi-x86_64: >> +tsan-build: > > to buildtest-developer? is CFI a dev feature or a distro feature? > Arguably they could be grouped together. > > <snip> >> +# These targets are on the way out >> +build-deprecated: >> +check-deprecated: > > buildtest-developer or even buildtest-deprecated? > > <snip> >> +gprof-gcov: >> +build-oss-fuzz: > > buildtest-developer? > >> +build-tci: >> +build-coroutine-sigaltstack: > > buildtest-custom? > > <snip> >> +crypto-old-nettle: >> +crypto-old-gcrypt: > > buildtest-custom or buildtest-legacy? > >> +crypto-only-gnutls: >> +build-without-default-devices: >> +build-without-default-features: > > buildtest-custom. > >> +check-patch: >> +check-dco: > > buildtest-developer or maybe their own pr-qa? > >> +build-libvhost-user: >> + stage: build >> + image: $CI_REGISTRY_IMAGE/qemu/fedora:latest >> + needs: >> + job: amd64-fedora-container >> + before_script: >> + - dnf install -y meson ninja-build >> + script: >> + - mkdir subprojects/libvhost-user/build >> + - cd subprojects/libvhost-user/build >> + - meson >> + - ninja > > I dunno, buildtest-misc? > >> +# No targets are built here, just tools, docs, and unit tests. This >> +# also feeds into the eventual documentation deployment steps later >> +build-tools-and-docs-debian: >> +pages: > > Seems these could be under their own documentation section? >