On Tue, May 11, 2021 at 03:54:26PM +0200, Thomas Huth wrote: > On 11/05/2021 15.26, Daniel P. Berrangé wrote: > > It has been over two years since RHEL-8 was released, and thus per the > > platform build policy, we no longer need to support RHEL-7 as a build > > target. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > .gitlab-ci.yml | 6 +++--- > > tests/docker/dockerfiles/centos8.docker | 1 + > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > index dcb6317aac..23917d6d73 100644 > > --- a/.gitlab-ci.yml > > +++ b/.gitlab-ci.yml > > @@ -441,12 +441,12 @@ build-user-plugins: > > MAKE_CHECK_ARGS: check-tcg > > timeout: 1h 30m > > -build-user-centos7: > > +build-user-centos8: > > <<: *native_build_job_definition > > needs: > > - job: amd64-centos7-container > > + job: amd64-centos8-container > > variables: > > - IMAGE: centos7 > > + IMAGE: centos8 > > We urgently should decrease our huge amount of jobs ... What about removing > this job completely? We already have the "build-user" job that tests the > compilation on Debian, which is likely at a similar library level as > centos8, so I doubt that we get much additional test coverage from this job > here when it's running on Centos 8.
This job was added by Philippe just a couple of months ago commit 4e41d4a34e4d9f11a99a03c2279f84e98df21984 Author: Philippe Mathieu-Daudé <f4...@amsat.org> Date: Thu Jan 21 18:28:29 2021 +0100 gitlab-ci: Test building linux-user targets on CentOS 7 Add a configuration tested by Peter Maydell (see [1] and [2]) but not covered in our CI [3]: [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o ../linux-user/strace.c: In function 'do_print_sockopt': ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function) case IPV6_ADDR_PREFERENCES: ^ This job currently takes 31 minutes 32 seconds ([4]). [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html [3] https://gitlab.com/philmd/qemu/-/jobs/977408284 [4] https://gitlab.com/philmd/qemu/-/jobs/978223286 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Reviewed-by: Thomas Huth <th...@redhat.com> Reviewed-by: Wainer dos Santos Moschetta <waine...@redhat.com> Message-Id: <20210121172829.1643620-3-f4...@amsat.org> Signed-off-by: Thomas Huth <th...@redhat.com> I looked at the quoted thread, but I can't tell what the actual missing scenario was that motivated this. The threads don't appear to specifically mention CentOS 7, but if the issue was indeed specific to CentOS 7 we can certainly drop the job. If it was some other scenario, I defer the answer to someone who knows.... Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|