On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so > if load_snapshot succeeds. > > Fix the bug in QMP by moving the common code to load_snapshot.
This doesn't appear to have actually fixed the HMP regression. Instead I think it is duplicated the HMP bug in the QMP code too. See the 068 iotest enhancement here that validates the expected state on success: https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg03091.html Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|