Hi On Tue, May 11, 2021 at 8:42 PM Stefan Hajnoczi <[email protected]> wrote:
> On Thu, Apr 29, 2021 at 05:40:25PM +0400, [email protected] > wrote: > > From: Marc-André Lureau <[email protected]> > > > > Move the generating function to the QAPISchemaIfCond class. > > I'm not familiar enough with the QAPI code generator to know whether > schema.py is supposed to generate C code directly. Otherwise this > refactoring makes sense. > I made the QAPISchemaIfCond simple enough so it can generate C or doc-friendly conditions in a couple of lines. So it has both data and generation in its current form. We could make it use a visitor pattern for the generation, but that's overkill at this point. thanks for the review! -- Marc-André Lureau
