On 5/12/21 1:43 PM, Markus Armbruster wrote:
Marc-André Lureau <[email protected]> writes:
Hi Markus
On Tue, May 11, 2021 at 8:53 PM Stefan Hajnoczi <[email protected]> wrote:
On Thu, Apr 29, 2021 at 05:40:23PM +0400, [email protected]
wrote:
From: Marc-André Lureau <[email protected]>
Hi,
This series makes the 'if' conditions less liberal, by formalizing a
simple
expression tree based on bare boolean logic of configure option
identifiers.
(this allows to express conditions in Rust in my QAPI-Rust PoC series)
This is based on John Snow QAPI pt4:
https://patchew.org/QEMU/[email protected]/
Based-on: <[email protected]>
The patch series applies cleanly on top of master now. I checked no
regression between each commit, including python style checks.
Appears to conflict with John's "[PATCH v2 00/21] qapi: static typing
conversion, pt5a". I didn't examine the conflicts.
Since I reviewed John's v1 recently, and git-range-diff to v2 looks
fairly innocent at a glance, I'd prefer not to rock that boat. Let's
discuss what to do as soon as I reviewed John's v2.
It should hopefully be very minimal. I advised Marc-Andre to rebase on
master as this series did not appear to touch the parser. Conflict
should be minimal-ish.
(Maybe it's clashing in Schema just a little bit? I do touch schema.py
very gently...)
If you are overloaded, can I make a pull request for it?
Not yet, please.
As soon as I am done sending a new version of my Python packaging and CI
series I will run this through the wringer and give my reviews.
--js
