On 2011-10-02 18:39, Avi Kivity wrote: > On 09/28/2011 09:01 PM, Blue Swirl wrote: >> On Wed, Sep 28, 2011 at 11:00 AM, Jan Kiszka<jan.kis...@siemens.com> >> wrote: >> > As we clearly modify the PIC state on pic_reset, we also have to >> update >> > the IRQ output. This only happened on init so far. Apply this >> > consistently. >> >> Nack, IRQ lines shouldn't be touched on reset. The other side may not >> be ready for receiving the interrupt change and qemu_irqs are >> stateless anyway. >> > > The way to fix it is two-phase reset: > > phase 1: reset internal state (-> move all outputs to reset values), > don't sample inputs yet > phase 2: allow sampling inputs
As far as I understood Anthony's QOM plans, phase 1 will correspond to "unrealize", phase 2 to "realize". However, we do not depend on two phases in this particular case (i8259) and can live with a coalescing both for now. Jan
signature.asc
Description: OpenPGP digital signature
