On Fri, 30 Apr 2021 at 22:18, Richard Henderson <richard.hender...@linaro.org> wrote: > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -1487,9 +1487,49 @@ DO_CMLA(sve2_sqrdcmlah_zzzz_h, int16_t, H2, > DO_SQRDMLAH_H) > DO_CMLA(sve2_sqrdcmlah_zzzz_s, int32_t, H4, DO_SQRDMLAH_S) > DO_CMLA(sve2_sqrdcmlah_zzzz_d, int64_t, , DO_SQRDMLAH_D) > > +#undef DO_SQRDMLAH_B > +#undef DO_SQRDMLAH_H > +#undef DO_SQRDMLAH_S > +#undef DO_SQRDMLAH_D > #undef do_cmla > #undef DO_CMLA
Maybe these undefs should go in an earlier patch? Or perhaps we just shouldn't use the same DO_foo name for two different operations... Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM