On Fri, 30 Apr 2021 at 22:20, Richard Henderson <richard.hender...@linaro.org> wrote: > > From: Stephen Long <stepl...@quicinc.com> > > Signed-off-by: Stephen Long <stepl...@quicinc.com> > Message-Id: <20200428174332.17162-2-stepl...@quicinc.com> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/helper-sve.h | 5 +++++ > target/arm/sve.decode | 4 ++++ > target/arm/sve_helper.c | 20 ++++++++++++++++++++ > target/arm/translate-sve.c | 16 ++++++++++++++++ > 4 files changed, 45 insertions(+)
> +DO_FCVTNT(sve2_fcvtnt_sh, uint32_t, uint16_t, H1_4, H1_2, sve_f32_to_f16) > +DO_FCVTNT(sve2_fcvtnt_ds, uint64_t, uint32_t, H1_4, H1_2, float64_to_float32) Shouldn't these be using different HW and HN macros ? They're operating on different type sizes... Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM