On 12/05/2021 15:34, Richard Henderson wrote:
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote:
From: "Lucas Mateus Castro (alqotel)"<lucas.ara...@eldorado.org.br>
Added tlb_set_page and tlb_set_page_with_attrs to the
stubbed functions in exec-all.h as it is needed
in some functions when compiling without TCG
Signed-off-by: Lucas Mateus Castro
(alqotel)<lucas.ara...@eldorado.org.br>
---
include/exec/exec-all.h | 10 ++++++++++
1 file changed, 10 insertions(+)
No, the caller is tcg-specific already.
r~
tlb_set_page is called by many ppc_hash64_handle_mmu_fault,
ppc_radix64_handle_mmu_fault and ppc_hash32_handle_mmu_fault, all of
which from what I've seen are only used inside #if
defined(CONFIG_SOFTMMU). So what is the best way to deal with these
tlb_set_page calls? Should these part of the _handle_mmu_fault functions
never be reached or should these functions never be called?
If it's the latter then should we change the #if defined to #if
defined(CONFIG_SOFTMMU) && (CONFIG_TCG)?
P.S: There was a miscommunication between me and Bruno, this should've
been a RFC.
