Le 08/05/2021 à 06:34, Thomas Huth a écrit : > On 07/05/2021 17.53, Jagannathan Raman wrote: >> Fixes an if statement that performs a logical AND of mutually exclusive >> tests >> >> Reported-by: Thomas Huth <th...@redhat.com> > > I just spotted the bug ticket on Launchpad :-) So whoever picks this patch > up, please add this instead: > > Buglink: https://bugs.launchpad.net/qemu/+bug/1926995 > Reviewed-by: Thomas Huth <th...@redhat.com>
Applied to my trivial-patches branch. Thanks, Laurent >> Signed-off-by: Jagannathan Raman <jag.ra...@oracle.com> >> --- >> hw/remote/mpqemu-link.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/remote/mpqemu-link.c b/hw/remote/mpqemu-link.c >> index 9ce3152..e67a5de 100644 >> --- a/hw/remote/mpqemu-link.c >> +++ b/hw/remote/mpqemu-link.c >> @@ -218,7 +218,7 @@ uint64_t mpqemu_msg_send_and_await_reply(MPQemuMsg *msg, >> PCIProxyDev *pdev, >> bool mpqemu_msg_valid(MPQemuMsg *msg) >> { >> - if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) { >> + if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) { >> return false; >> } > >