Hi Philippe,
On Fri, May 14, 2021 at 12:57 AM Philippe Mathieu-Daudé
<phi...@redhat.com> wrote:
>
> Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART
> emulation") added a dependency on the SERIAL model, but forgot to
> add the Kconfig selector. Fix that to solve when built the
> MICROCHIP_PFSOC machine stand-alone:
>
> /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function
> `mchp_pfsoc_mmuart_create':
> hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init'
>
> Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation")
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> ---
> Cc: Bin Meng <bin.m...@windriver.com>
> Cc: Alistair Francis <alistair.fran...@wdc.com>
> ---
> hw/riscv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
> index 86957ec7b06..b72a248809e 100644
> --- a/hw/riscv/Kconfig
> +++ b/hw/riscv/Kconfig
> @@ -12,6 +12,7 @@ config MICROCHIP_PFSOC
> select SIFIVE_CLINT
> select SIFIVE_PDMA
> select SIFIVE_PLIC
> + select SERIAL
This dependency should be expressed by MCHP_PFSOC_MMUART in hw/char/Kconfig
> select UNIMP
>
> config OPENTITAN
> --
Regards,
Bin
