On 10/04/2011 08:35 PM, Juan Quintela wrote:
Avi Kivity<a...@redhat.com> wrote:
> On 10/04/2011 04:38 PM, Juan Quintela wrote:
>> Hi
>>
>> This series move the subsections detection code form:
>> - Look that it starts form 5
>> To:
>> - Look that it starts form 5 (SUBSECTION)
>> - Look at the length
>> - Look that length is bigger than section name
>> - Look at the idstr and see that it starts with the subsection name.
>>
>> Please review.
>>
>
> The original intent with subsections was to register them as a new
> vmstate section, with just a name relationship.
>
> Can we rename .subsections to .old_and_semi_broken_subsections, and
> introduce a new .subsections field that works properly in all cases?
Not easily. We can try to do something, but the problem is that
subsection are just that "sub", and we should have to be very careful
with post-load handlers.
If necessary the subsection's post-load handler can re-run the main
post-load handler (or it can even be the same post-load handler,
unconditionally). We just have to make sure that post-load handlers are
idempotent.
--
error compiling committee.c: too many arguments to function
