On 21/05/21 16:06, Mirela Grujic wrote:
PHASE_NO_MACHINE
-> machine-set -> PHASE_MACHINE_CREATED ->
-> accel-set -> PHASE_ACCEL_CREATED -> PHASE_MACHINE_INITIALIZED ->
My understanding is that an equivalent of previously supported
'preconfig' state is PHASE_ACCEL_CREATED, from the perspective of the
QMP configuration that Igor implemented. In other words, I believe that
when -preconfig CLI option was passed, QEMU was waiting for the QMP
configuration in PHASE_ACCEL_CREATED phase. Now, if accel-set advances
the machine directly to PHASE_MACHINE_INITIALIZED, there will be no
chance to configure what Igor did with -preconfig.
Right, that was only NUMA. I have to check, but I think it can be moved
to PHASE_MACHINE_CREATED.
Apart from that, if we add a third command for the CPU model, that third
command would run from PHASE_ACCEL_CREATED so the pre-existing preconfig
state would be accessible.
Paolo
Is this something you don't want to support anymore, or it can be
configured in another way? Or is this something that we haven't thought
of yet, but we should?