On 5/24/21 11:01 AM, Bruno Piazera Larsen wrote:
+#ifdef CONFIG_TCG
cc->dump_statistics = ppc_cpu_dump_statistics;
+#endif
We should just drop this entirely. It's supposedly a generic thing, but only
used by ppc. But even then only with source modification to enable
DO_PPC_STATISTICS. And even then as we convert to decodetree, said
statistics will not be collected.
We should delete everything from cpu_dump_statistics on down.
So, now that we have a version of disable-tcg that is functional, I'm inclined
to look at this cleanup. Just to make sure I got it right: everything related
to ppc_cpu_dump_statistics and the stuff related to ifdef DO_PPC_STATISTICS can
be removed, yeah?
I would imagine a set of patches:
(1) DO_PPC_STATISTICS
(2) ppc_cpu_dump_statistics (which will be empty now).
(3) CPUClass.dump_statistics (which now has no setters),
and cpu_dump_statistics (which is closely related).
(4) hmp_info_cpustats (which now does nothing).
r~