Hey Richard, I think I submitted the wrong patch, sorry about that. I will go ahead and submit the correct commit id now. What I was trying to do was, when kvm is enabled and if we don't want to include CONFIG_ARM_VIRT or CONFIG_ACPI_APEI, compilation fails as virt_is_acpi_enabled() routine is defined in virt.h and acpi_ghes_record_errors() is defined in ghes.h.
~ Swetha On Mon, May 24, 2021 at 6:53 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 5/24/21 3:56 PM, Swetha Joshi wrote: > > From: Swetha <swjo...@microsoft.com> > > > > Signed-off-by: Swetha <swjo...@microsoft.com> > > What are you trying to accomplish? > That's what belongs in the commit message that you omitted. > > > + bool acpi_enabled = false; > > +#ifdef CONFIG_ARM_VIRT > > bool acpi_enabled = virt_is_acpi_enabled(vms); > > Of course this doesn't compile, having declared acpi_enabled twice. So > you > have clearly not tested this patch sufficiently. > > The cc to qemu-trivial is unwarranted. > > > r~ > -- Regards Swetha Joshi.
