On Mon, May 24, 2021 at 07:01:20PM -0700, Richard Henderson wrote:
> On 5/21/21 1:17 PM, Bruno Larsen (billionai) wrote:
> > +    uint32_t mask = 1u << bit;
> > +    if (env->fpscr & mask) {
> > +        ppc_store_fpscr(env, env->fpscr & ~mask);
> 
> Oops, missed this during review but:
> 
>   fpscr & ~(target_ulong)mask;
> 
> Otherwise we clear high bits of fpscr incorrectly.

Oops, good point.  I've removed the previous version from ppc-for-6.1,
and I'll wait for a respin.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature

Reply via email to