On Thu, Apr 08, 2021 at 05:08:27PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We now have bs-independent connection API, which consists of four > functions: > > nbd_client_connection_new() > nbd_client_connection_unref() > nbd_co_establish_connection() > nbd_co_establish_connection_cancel() > > Move them to a separate file together with NBDClientConnection > structure which becomes private to the new API. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > > Hmm. I keep only Virtuozzo's copyright in a new file, as actually I've > developed nbd-reconnection code. Still probably safer to save all > copyrights. Let me now if you think so and I'll add them.
I trust git's version log better than what the file header itself states. But in this particular case (the new file has only functions that you demonstrably contributed), I think you are okay in listing only your own copyright, instead of carrying along everything else from the file you split out of. If anyone objects, we can always add the details back in. However, it may be good to include a disclaimer in your commit message proper mentioning your choice in copyright on the new file. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
