On Thu, 27 May 2021 at 06:24, Yoshinori Sato <ys...@users.sourceforge.jp> wrote: > > Migrate to renesas_sci. > > Signed-off-by: Yoshinori Sato <ys...@users.sourceforge.jp> > --- > hw/char/sh_serial.c | 431 -------------------------------------------- > MAINTAINERS | 4 +- > hw/char/Kconfig | 3 - > hw/char/meson.build | 1 - > 4 files changed, 2 insertions(+), 437 deletions(-) > delete mode 100644 hw/char/sh_serial.c
This won't compile, because there are still boards which use the old code you are removing here. The patchset has to be able to compile and work at every step, so you need to first add new devices, then convert the boards to use them, and then as the last step you can remove the old implementations. Checking, I find that patch 1 doesn't compile either. thanks -- PMM