On Mon, Jun 07, 2021 at 12:23:08PM +1000, David Gibson wrote: > On Fri, Jun 04, 2021 at 05:03:52PM -0300, Daniel Henrique Barboza wrote: > > At this moment we only provide one event to report a hotunplug error, > > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries > > machine is now able to report unplug errors for other device types, such > > as CPUs. > > > > Instead of creating a (device_type)_UNPLUG_ERROR for each new device, > > create a generic DEVICE_UNPLUG_ERROR event that can be used by all > > unplug errors in the future. > > > > Signed-off-by: Daniel Henrique Barboza <danielhb...@gmail.com> > > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Markus, I'm happy to take this through my tree if that's convenient for you, but I'd like to get an ack. > > > --- > > qapi/machine.json | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/qapi/machine.json b/qapi/machine.json > > index 58a9c86b36..f0c7e56be0 100644 > > --- a/qapi/machine.json > > +++ b/qapi/machine.json > > @@ -1274,3 +1274,26 @@ > > ## > > { 'event': 'MEM_UNPLUG_ERROR', > > 'data': { 'device': 'str', 'msg': 'str' } } > > + > > +## > > +# @DEVICE_UNPLUG_ERROR: > > +# > > +# Emitted when a device hot unplug error occurs. > > +# > > +# @device: device name > > +# > > +# @msg: Informative message > > +# > > +# Since: 6.1 > > +# > > +# Example: > > +# > > +# <- { "event": "DEVICE_UNPLUG_ERROR" > > +# "data": { "device": "dimm1", > > +# "msg": "Memory hotunplug rejected by the guest for device > > dimm1" > > +# }, > > +# "timestamp": { "seconds": 1615570772, "microseconds": 202844 } } > > +# > > +## > > +{ 'event': 'DEVICE_UNPLUG_ERROR', > > + 'data': { 'device': 'str', 'msg': 'str' } } > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature