On Tue, Jun 08, 2021 at 12:16:03AM +0800, Hyman Huang wrote: [...]
> > Actually I'm also wondering whether dirty log could be anything useful here > > in > > the future as a 3rd mode (then the "*mode" idea should be more useful if > > so), > > basically for old kernels where dirty ring is not there, we can timely call > > memory_global_dirty_log_sync() and calculate dirty pages there just like > > what > > we do with dirty rings (without calling migration_bitmap_sync(), so we don't > > need to deliver dirty bits from kvmslots to ramblocks, just pick them up > > from > > kvm and do the accounting for pure dirty rate measurement). That's a wild > > idea > > though, so just raise it up. Would that be anything useful? > uh, actually this idea is what i'm working on to stat the memory heat(trying > to reduce the transferred memory in migration), theoretically it can be used > for dirty rate measurement also, maybe i could try it after this patchset > work having done. Yes, definitely no need to do that in this series; it just proves that "*mode" parameter is better in case a 3rd one could come. Thanks, -- Peter Xu
