Re: [PATCH 2/2] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features()

[Jason Wang]

在 2021/6/6 上午1:19, Gautam Dawar 写道:

No user for this helper, let's remove it.

[GD>>]  These patches seem unrelated to me. Do you think they should be part of 
one patch series?

It doesn't harm.

I've queued this patch.

Thanks

Signed-off-by: Jason Wang <jasow...@redhat.com>
---
  include/net/vhost-vdpa.h | 1 -
  net/vhost-vdpa.c         | 9 ---------
  2 files changed, 10 deletions(-)

diff --git a/include/net/vhost-vdpa.h b/include/net/vhost-vdpa.h index 
45e34b7cfc..b81f9a6f2a 100644
--- a/include/net/vhost-vdpa.h
+++ b/include/net/vhost-vdpa.h
@@ -15,7 +15,6 @@
  #define TYPE_VHOST_VDPA "vhost-vdpa"

struct vhost_net *vhost_vdpa_get_vhost_net(NetClientState *nc); -uint64_t vhost_vdpa_get_acked_features(NetClientState *nc); extern const int vdpa_feature_bits[]; diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index fe659ec9e2..8dc86332a6 100644

--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -66,15 +66,6 @@ VHostNetState *vhost_vdpa_get_vhost_net(NetClientState *nc)
      return s->vhost_net;
  }

-uint64_t vhost_vdpa_get_acked_features(NetClientState *nc) -{

-    VhostVDPAState *s = DO_UPCAST(VhostVDPAState, nc, nc);
-    assert(nc->info->type == NET_CLIENT_DRIVER_VHOST_VDPA);
-    s->acked_features = vhost_net_get_acked_features(s->vhost_net);
-
-    return s->acked_features;
-}
-
  static int vhost_vdpa_net_check_device_id(struct vhost_net *net)  {
      uint32_t device_id;
--
2.25.1