Patchew URL: https://patchew.org/QEMU/cover.1623027729.git.huang...@chinatelecom.cn/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1623027729.git.huang...@chinatelecom.cn Subject: [PATCH v3 0/7] support dirtyrate at the granualrity of vcpu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' db25537 migration/dirtyrate: implement dirty-ring dirtyrate calculation 720f923 memory: make global_dirty_log a bitmask a3323fd migration/dirtyrate: adjust struct DirtyRateStat 04b16bd migration/dirtyrate: add per-vcpu option for calc-dirty-rate 0ec6909 KVM: introduce dirty_pages and kvm_dirty_ring_enabled 8828757 hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds dd4342c migration/dirtyrate: make sample page count configurable === OUTPUT BEGIN === 1/7 Checking commit dd4342c3ec2f (migration/dirtyrate: make sample page count configurable) 2/7 Checking commit 8828757e0b0e (hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds) 3/7 Checking commit 0ec6909b55f6 (KVM: introduce dirty_pages and kvm_dirty_ring_enabled) 4/7 Checking commit 04b16bd9b236 (migration/dirtyrate: add per-vcpu option for calc-dirty-rate) ERROR: Error messages should not contain newlines #42: FILE: migration/dirtyrate.c:427: + "only one of then can be specified!\n"); total: 1 errors, 0 warnings, 158 lines checked Patch 4/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/7 Checking commit a3323fddecd9 (migration/dirtyrate: adjust struct DirtyRateStat) 6/7 Checking commit 720f923fec0d (memory: make global_dirty_log a bitmask) ERROR: spaces required around that '<<' (ctx:VxV) #36: FILE: include/exec/memory.h:58: +#define GLOBAL_DIRTY_MIGRATION (1U<<0) ^ ERROR: spaces required around that '<<' (ctx:VxV) #37: FILE: include/exec/memory.h:59: +#define GLOBAL_DIRTY_DIRTY_RATE (1U<<1) ^ total: 2 errors, 0 warnings, 145 lines checked Patch 6/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/7 Checking commit db255379e746 (migration/dirtyrate: implement dirty-ring dirtyrate calculation) ERROR: do not initialise globals to 0 or NULL #75: FILE: migration/dirtyrate.c:47: +bool register_powerdown_callback = false; WARNING: Block comments use a leading /* on a separate line #208: FILE: migration/dirtyrate.c:437: + /* migration is in process, do not stop dirty logging, WARNING: Block comments use a trailing */ on a separate line #209: FILE: migration/dirtyrate.c:438: + * just clear the GLOBAL_DIRTY_DIRTY_RATE bit */ total: 1 errors, 2 warnings, 322 lines checked Patch 7/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1623027729.git.huang...@chinatelecom.cn/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com