On Tue, 8 Jun 2021 at 22:33, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> On 6/7/21 9:57 AM, Peter Maydell wrote:
> > +#define DO_VLDR(OP, ESIZE, LDTYPE, TYPE, H) \
> > + void HELPER(mve_##OP)(CPUARMState *env, void *vd, uint32_t addr) \
> > + { \
> > + TYPE *d = vd; \
> > + uint16_t mask = mve_element_mask(env); \
> > + unsigned b, e; \
>
> esize is redundant with sizeof(type); perhaps just make it a local variable?
That's OK here, but not for most of the other macros, where we need
ESIZE as a macro argument so we can do mask_to_bytemask##ESIZE.
-- PMM
