Patchew URL: https://patchew.org/QEMU/20210613211549.18094-1-thor...@me.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210613211549.18094-1-thor...@me.com Subject: [PATCH 0/4] Emulator fixes to enable running NetBSD/alpha === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210610001424.209158-1-jiang.w...@bytedance.com -> patchew/20210610001424.209158-1-jiang.w...@bytedance.com * [new tag] patchew/20210612085101.61304-1...@weilnetz.de -> patchew/20210612085101.61304-1...@weilnetz.de Switched to a new branch 'test' ae5541d alpha: Provide console information to the PALcode at start-up. ed14ccc alpha: Provide a PCI-ISA bridge device node for guest OS's that expect it 4ab8e91 alpha: Set minimum PCI device ID to 1 to match Clipper IRQ mappings. 8e9fae5 mc146818rtc: Make PF independent of PIE === OUTPUT BEGIN === 1/4 Checking commit 8e9fae55ef15 (mc146818rtc: Make PF independent of PIE) 2/4 Checking commit 4ab8e91bd35e (alpha: Set minimum PCI device ID to 1 to match Clipper IRQ mappings.) WARNING: Block comments use a leading /* on a separate line #46: FILE: hw/alpha/dp264.c:79: + /* Init the chipset. Because we're using CLIPPER IRQ mappings, WARNING: Block comments use * on subsequent lines #47: FILE: hw/alpha/dp264.c:80: + /* Init the chipset. Because we're using CLIPPER IRQ mappings, + the minimum PCI device IdSel is 1. */ WARNING: Block comments use a trailing */ on a separate line #47: FILE: hw/alpha/dp264.c:80: + the minimum PCI device IdSel is 1. */ total: 0 errors, 3 warnings, 37 lines checked Patch 2/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/4 Checking commit ed14ccc6e1b5 (alpha: Provide a PCI-ISA bridge device node for guest OS's that expect it) WARNING: Block comments use a leading /* on a separate line #29: FILE: hw/alpha/typhoon.c:922: + /* Init the PCI-ISA bridge. Technically, PCI-based Alphas shipped WARNING: Block comments use * on subsequent lines #30: FILE: hw/alpha/typhoon.c:923: + /* Init the PCI-ISA bridge. Technically, PCI-based Alphas shipped + with one of three different PCI-ISA bridges: WARNING: Block comments use a trailing */ on a separate line #49: FILE: hw/alpha/typhoon.c:942: + Tsunami/Typhoon systems. */ WARNING: Block comments use a leading /* on a separate line #62: FILE: hw/alpha/typhoon.c:978: +/* The following was copied from hw/isa/i82378.c and modified to provide WARNING: Block comments use * on subsequent lines #63: FILE: hw/alpha/typhoon.c:979: +/* The following was copied from hw/isa/i82378.c and modified to provide + only the minimal PCI device node. */ WARNING: Block comments use a trailing */ on a separate line #63: FILE: hw/alpha/typhoon.c:979: + only the minimal PCI device node. */ total: 0 errors, 6 warnings, 130 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit ae5541d5739e (alpha: Provide console information to the PALcode at start-up.) WARNING: Block comments use a leading /* on a separate line #25: FILE: hw/alpha/dp264.c:75: + /* arg0 -> memory size WARNING: Block comments use * on subsequent lines #26: FILE: hw/alpha/dp264.c:76: + /* arg0 -> memory size + arg1 -> kernel entry point WARNING: Block comments use a trailing */ on a separate line #32: FILE: hw/alpha/dp264.c:82: + See init_hwrpb() in the PALcode. */ ERROR: suspect code indent for conditional statements (4, 6) #37: FILE: hw/alpha/dp264.c:87: + if (!machine->enable_graphics) + cpus[0]->env.trap_arg2 |= (1 << 6); ERROR: braces {} are necessary for all arms of this statement #37: FILE: hw/alpha/dp264.c:87: + if (!machine->enable_graphics) [...] total: 2 errors, 3 warnings, 20 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210613211549.18094-1-thor...@me.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
