On 6/14/2021 1:45 AM, Philippe Mathieu-Daudé wrote:
On 6/13/21 8:33 AM, Stefan Weil wrote:
Am 13.06.21 um 03:40 schrieb Brad Smith:
This same problem also applies to OpenBSD as we have the same
version of ncurses with support for wide characters. I have a similar
patch in our QEMU port.
Then we should either extend the conditional statement to handle OpenBSD
as well, or simply define both macros unconditionally:
# Newer versions of curses use NCURSES_WIDECHAR.
# Older versions (e. g. on MacOS, OpenBSD) still require
_XOPEN_SOURCE_EXTENDED.
curses_compile_args = ['-DNCURSES_WIDECHAR=1',
'-D_XOPEN_SOURCE_EXTENDED=1']
Defining only _XOPEN_SOURCE_EXTENDED would also work with old and new
versions, so that's another option.
It is simpler to ask Brad to upstream the OpenBSD patch :)
That doesn't answer his question and that's the part that actually matters.
