On 6/16/21 3:12 AM, Richard Henderson wrote: > Create and record the two signal trampolines. > > Cc: Philippe Mathieu-Daudé <f4...@amsat.org> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > linux-user/mips/target_signal.h | 1 + > linux-user/mips64/target_signal.h | 2 ++ > linux-user/mips/signal.c | 39 ++++++++++++++++++++----------- > 3 files changed, 28 insertions(+), 14 deletions(-)
> diff --git a/linux-user/mips/signal.c b/linux-user/mips/signal.c > index e6be807a81..234f85905b 100644 > --- a/linux-user/mips/signal.c > +++ b/linux-user/mips/signal.c > @@ -86,10 +86,8 @@ struct target_rt_sigframe { > }; > > /* Install trampoline to jump back from signal handler */ > -static inline int install_sigtramp(unsigned int *tramp, unsigned int > syscall) > +static void install_sigtramp(unsigned int *tramp, unsigned int syscall) Preferably modifying install_sigtramp() in previous patch, changing tramp as uint32_t*: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > { > - int err = 0; > - > /* > * Set up the return code ... > * > @@ -99,7 +97,6 @@ static inline int install_sigtramp(unsigned int *tramp, > unsigned int syscall) > > __put_user(0x24020000 + syscall, tramp + 0); > __put_user(0x0000000c , tramp + 1); > - return err; > }