On 6/16/21 8:38 PM, Richard Henderson wrote: > On 6/16/21 9:14 AM, Philippe Mathieu-Daudé wrote: >> lm832x_key_event() is specific go LM832x devices, not to the >> I2C bus API. Move it out of "i2c.h" to a new header. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> --- >> include/hw/i2c/i2c.h | 3 --- >> include/hw/input/lm832x.h | 26 ++++++++++++++++++++++++++ >> hw/arm/nseries.c | 1 + >> hw/input/lm832x.c | 1 + >> MAINTAINERS | 1 + >> 5 files changed, 29 insertions(+), 3 deletions(-) >> create mode 100644 include/hw/input/lm832x.h > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > >> +#ifndef HW_INPUT_LM832X >> +#define HW_INPUT_L > > You fix this error in the next patch, but better here.
Oops! I didn't noticed... Something got wrong while re-ordering during rebase, thanks for telling me!