On 6/21/21 3:47 PM, Richard Henderson wrote: > On 6/21/21 5:50 AM, Philippe Mathieu-Daudé wrote: >> I notice various targets do: >> >> #ifdef CONFIG_USER_ONLY >> return true; >> #else >> >>> + /* Check for the dest on the same page as the start of the TB. */ >>> + return ((db->pc_first ^ dest) & TARGET_PAGE_MASK) == 0; >> #endif >> >>> +} >> Is that OK to remove this case? If so, it might be worth a comment >> somewhere. > > I mentioned it in the cover letter.
But the commit letter will vanish, so preferably mentioning the change in the commit description (copying the cover letter comment could work too): Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
