On Mon, Jun 28, 2021 at 5:16 PM Wainer dos Santos Moschetta < waine...@redhat.com> wrote:
> Hi, > > On 6/25/21 12:45 PM, John Snow wrote: > > Move it up near the check-pipenv help text, and update it to suggest > parity. > > > > (At the time I first added it, I wasn't sure if I would be keeping it, > > but I've come to appreciate it as it has actually helped uncover bugs I > > would not have noticed without it. It should stay.) > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > python/Makefile | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/python/Makefile b/python/Makefile > > index 07ad73ccd0..5cb8378b81 100644 > > --- a/python/Makefile > > +++ b/python/Makefile > > @@ -9,13 +9,17 @@ help: > > @echo " Requires: Python 3.6 and pipenv." > > @echo " Hint (Fedora): 'sudo dnf install python3.6 pipenv'" > > @echo "" > > + @echo "make check-tox:" > > + @echo " Run tests against multiple python versions." > > + @echo " These tests use the newest dependencies." > > + @echo " Requires: Python 3.6-3.10 and tox." > > Nit: I'm not sure it is clear '3.6-3.10' is a range rather than a > specific version. > It was meant to be a range. Would you prefer "3.6 - 3.10" instead, then? > > - Wainer >
