On 03/07/2021 15:19, Philippe Mathieu-Daudé wrote:

Per the DP83932C datasheet from July 1995:

   1. Functional Description
   1.3 DATA WIDTH AND BYTE ORDERING

     The SONIC can be programmed to operate with
     either 32-bit or 16-bit wide memory.

Restrict the memory bus to reject 8/64-bit accesses.

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
  hw/net/dp8393x.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index d16ade2b198..c9b478c127c 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -695,6 +695,8 @@ static const MemoryRegionOps dp8393x_ops = {
      .write = dp8393x_write,
      .impl.min_access_size = 2,
      .impl.max_access_size = 2,
+    .valid.min_access_size = 2,
+    .valid.max_access_size = 4,
      .endianness = DEVICE_NATIVE_ENDIAN,
  };

Unfortunately this patch breaks MacOS - it seems very early in startup the MacOS toolbox probes for the presence of the network adapter using single byte accesses which are rejected by this change :(

I'd suggest that we simply drop this patch.


ATB,

Mark.

Reply via email to