On Thu, 24 Jun 2021 03:55:35 +0000
Taylor Simpson <tsimp...@quicinc.com> wrote:
> > +void gen_deposit_op(Context *c,
> > + YYLTYPE *locp,
> > + HexValue *dest,
> > + HexValue *value,
> > + HexValue *index,
> > + HexCast *cast)
>
> What's the difference between this and the gen_rdeposit_op above?
`gen_deposit_op` expects index and width (cast) to be immediates, while
`gen_rdeposit_op` does not.
We could merge them together, but it would just be a big "if" over the
whole function.
> > +HexValue gen_rextract_op(Context *c,
> > + YYLTYPE *locp,
> > + HexValue *source,
> > + int begin,
> > + int width) {
> > +
> > +HexValue gen_extract_op(Context *c,
> > + YYLTYPE *locp,
> > + HexValue *source,
> > + HexValue *index,
> > + HexExtract *extract) {
>
> What's the difference between this ant the gen_rextract_op above?
As before.
--
Alessandro Di Federico
rev.ng
