On 7/9/21 11:26 AM, Igor Mammedov wrote: > On Wed, 7 Jul 2021 15:40:30 +0200 > Michal Privoznik <mpriv...@redhat.com> wrote: > >> When parsing cpus= attribute of -numa object couple of checks >> is performed, such as correct initiator setting (see the if() >> statement at the end of for() loop in >> machine_set_cpu_numa_node()). >> >> However, with the current code cpus= attribute is parsed before >> initiator= attribute and thus the check may fail even though it >> is not obvious why. But since parsing the initiator= attribute >> does not depend on the cpus= attribute we can swap the order of >> the two. > > Reviewed-by: Igor Mammedov <imamm...@redhat.com> > > FYI: > I'm planning to deprecate '-numa node,cpus=' in favor of '-numa cpu'.
Yes, I'm aware of that and I remember I posted some patches for libvirt that you reviewed. I need to return to them rather sooner than later. Meanwhile, this patch helps. Thanks, Michal
