> Add share=on for consistency and to prevent future bugs in the test. > > Note that share=on is the default for memory-backend-memfd so existing > tests work. > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Acked-by: Thomas Huth <th...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > tests/qtest/vhost-user-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c > index 3d6337fb5c..6c0891d429 100644 > --- a/tests/qtest/vhost-user-test.c > +++ b/tests/qtest/vhost-user-test.c > @@ -40,7 +40,7 @@ > #define QEMU_CMD_MEM " -m %d -object > memory-backend-file,id=mem,size=%dM," \ > "mem-path=%s,share=on -numa node,memdev=mem" > #define QEMU_CMD_MEMFD " -m %d -object > memory-backend-memfd,id=mem,size=%dM," \ > - " -numa node,memdev=mem" > + "share=on -numa node,memdev=mem" > #define QEMU_CMD_CHR " -chardev socket,id=%s,path=%s%s" > #define QEMU_CMD_NETDEV " -netdev vhost-user,id=hs0,chardev=%s,vhostforce" >
Reviewed-by: Pankaj Gupta <pankaj.gu...@ionos.com>