Hi On Wed, Jul 21, 2021 at 5:22 PM zhuguanghong <zhuguangh...@uniontech.com> wrote:
> Signed-off-by: zhuguanghong <zhuguangh...@uniontech.com> > --- > qom/object.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index 6a01d56546..c8f5481afe 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -78,9 +78,7 @@ static GHashTable *type_table_get(void) > { > static GHashTable *type_table; > > - if (type_table == NULL) { > - type_table = g_hash_table_new(g_str_hash, g_str_equal); > - } > + type_table = g_hash_table_new(g_str_hash, g_str_equal); > > nack.It's not redundant, it does a one-time initialization. We may want to replace it with a more explicit and thread-safe version though: https://developer.gnome.org/glib/stable/glib-Threads.html#g-once-init-enter return type_table; > } > -- > 2.20.1 > > > > > -- Marc-André Lureau