On Mon, 17 Oct 2011 21:20:59 +0200, Stefan Weil <s...@weilnetz.de> wrote:
> cppcheck report:
> hw/9pfs/virtio-9p.c:2385:
> style: Boolean result is used in bitwise operation.
> Clarify expression with parentheses
> hw/9pfs/virtio-9p.c:2531:
> style: Boolean result is used in bitwise operation.
> Clarify expression with parentheses
>
> Cc: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <s...@weilnetz.de>
> ---
> hw/9pfs/virtio-9p.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index c01c31a..df0b22a 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -2382,7 +2382,7 @@ static void v9fs_remove(void *opaque)
> goto out_nofid;
> }
> /* if fs driver is not path based, return EOPNOTSUPP */
> - if (!pdu->s->ctx.flags & PATHNAME_FSCONTEXT) {
> + if (!(pdu->s->ctx.flags & PATHNAME_FSCONTEXT)) {
> err = -EOPNOTSUPP;
> goto out_err;
> }
> @@ -2528,7 +2528,7 @@ static void v9fs_rename(void *opaque)
> }
> BUG_ON(fidp->fid_type != P9_FID_NONE);
> /* if fs driver is not path based, return EOPNOTSUPP */
> - if (!pdu->s->ctx.flags & PATHNAME_FSCONTEXT) {
> + if (!(pdu->s->ctx.flags & PATHNAME_FSCONTEXT)) {
> err = -EOPNOTSUPP;
> goto out;
> }
This is fixed in the new pull request i sent.
http://article.gmane.org/gmane.comp.emulators.qemu/120990
http://repo.or.cz/w/qemu/v9fs.git/commitdiff/c98f1d4a8bb6f779313043d2490093451cf52065?hp=7cca27dfde6435a7846d88e8a1fa927d0ab99919
-aneesh
