On 7/22/21 5:36 PM, Paolo Bonzini wrote: > The chardev-spicevmc class was not listed in chardev/spice.c, causing > "-chardev spicevmc" to fail when modules are enabled. > > Reported-by: Frederic Bezies <fredbez...@gmail.com> > Fixes: 9f4a0f0978 ("modules: use modinfo for qom load", 2021-07-09) > Resolves: //gitlab.com/qemu-project/qemu/-/issues/488
Thanks for the detail of updating to full url, however "https:' got lost ;) Gitlab doesn't notice because of the leading '//' I suppose. Not worth respining the pullreq. > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > Message-Id: <20210719164435.1227794-1-pbonz...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > chardev/spice.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/chardev/spice.c b/chardev/spice.c > index 3ffb3fdc0d..bbffef4913 100644 > --- a/chardev/spice.c > +++ b/chardev/spice.c > @@ -382,6 +382,7 @@ static const TypeInfo char_spicevmc_type_info = { > .parent = TYPE_CHARDEV_SPICE, > .class_init = char_spicevmc_class_init, > }; > +module_obj(TYPE_CHARDEV_SPICEVMC); > > static void char_spiceport_class_init(ObjectClass *oc, void *data) > { >