Philippe Mathieu-Daudé writes:
> First, all jobs depending on 'docker-opensbi' job must use at most > all the rules that triggers it. The simplest way to ensure that is > to always use the same rules. Extract all the rules to a reusable > section, and include this section (with the 'extends' keyword) in > both 'docker-opensbi' and 'build-opensbi' jobs. > > Second, jobs depending on another should not use the 'when: always' > condition, because if a dependency failed we should not keep running > jobs depending on it. The correct condition is 'when: on_success'. > > The problems were introduced in commit c6fc0fc1a71 ("gitlab-ci.yml: > Add jobs to build OpenSBI firmware binaries"), but were revealed in > commit 91e9c47e50a ("docker: OpenSBI build job depends on OpenSBI > container"). > > This fix is similar to the one used with the EDK2 firmware job in > commit ac0595cf6b3 ("gitlab-ci: Extract EDK2 job rules to reusable > section"). > > Reported-by: Daniel P. Berrangé <berra...@redhat.com> > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > Reviewed-by: Willian Rampazzo <willi...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > v2: when 'always' -> 'on_success' & reworded (danpb) > > Supersedes: <20210720164829.3949558-1-phi...@redhat.com> > --- > .gitlab-ci.d/opensbi.yml | 30 ++++++++++++++++++------------ > 1 file changed, 18 insertions(+), 12 deletions(-) > Reviewed-by: Cleber Rosa <cr...@redhat.com>