On Tue, Jul 27, 2021 at 5:17 AM Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Tue, 27 Jul 2021 at 01:39, Cleber Rosa <cr...@redhat.com> wrote: > > tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_aarch64_virt > > is currently failing consistently (first found that in [1]). > > FWIW I find that on my local machine this test is consistently flaky > and always has been, so I just ignore any failure I see in it when > running 'make check-acceptance' locally. > > -- PMM >
Hi Peter, Yes, I've spent quite some time with some flaky behavior while running the replay tests as well. But in the end, the test remained unchanged because we found the issues in the actual code under test (one time the recording of the replay file would sometimes be corrupted when using >=1 CPUs, but 100% of the time when using a single CPU). This time, it was failing 100% of the time in my experience, and now, after the fix in df3a2de51a07089a4a729fe1f792f658df9dade4, it's passing 100% of the time. So I guess even tests with some observed flakiness can have their value. Cheers, - Cleber.