On 8/4/2021 11:48 AM, Eric Blake wrote: > On Wed, Jul 07, 2021 at 10:20:12AM -0700, Steve Sistare wrote: >> cprsave calls cprsave(). Syntax: >> { 'enum': 'CprMode', 'data': [ 'reboot' ] } >> { 'command': 'cprsave', 'data': { 'file': 'str', 'mode': 'CprMode' } } >> >> cprload calls cprload(). Syntax: >> { 'command': 'cprload', 'data': { 'file': 'str' } } > > Does this also allow the magic "/dev/fdset/NNN" syntax for opening an > fd already passed in previously? > /me goes back to patch 2 to check > Yes, it looks like it should. > >> >> cprinfo returns a list of supported modes. Syntax: >> { 'struct': 'CprInfo', 'data': { 'modes': [ 'CprMode' ] } } >> { 'command': 'cprinfo', 'returns': 'CprInfo' } > > As pointed out elsewhere, relying on introspection seems nicer than > adding this command. > >> >> Signed-off-by: Mark Kanda <mark.ka...@oracle.com> >> Signed-off-by: Steve Sistare <steven.sist...@oracle.com> >> --- > >> +++ b/qapi/cpr.json >> @@ -0,0 +1,74 @@ >> +# -*- Mode: Python -*- >> +# >> +# Copyright (c) 2021 Oracle and/or its affiliates. >> +# >> +# This work is licensed under the terms of the GNU GPL, version 2. >> +# See the COPYING file in the top-level directory. >> + >> +## >> +# = CPR > > Might be worth expanding what this acronym stands for here.> >> +## >> + >> +{ 'include': 'common.json' } >> + >> +## >> +# @CprMode: >> +# >> +# @reboot: checkpoint can be cprload'ed after a host kexec reboot. >> +# >> +# Since: 6.1 > > As this missed 6.1, you'll need to (eventually) rebase the series to > mention 6.2 everywhere.
Will do for both. (Marc-Andre also asked). And I'll fix the indentation problem in patch 2. - Steve