On Wed, 4 Aug 2021 at 21:40, Eduardo Habkost <ehabk...@redhat.com> wrote: > > On Mon, Aug 02, 2021 at 01:19:14PM +0100, Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 19:01, Eduardo Habkost <ehabk...@redhat.com> wrote: > > > > > > When there's no specific class struct used for a QOM type, we > > > normally don't define a typedef for it. Remove the typedef from > > > the minimal example, as it is unnecessary.
> > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > > > though I agree with Daniel that in the long-term we should reverse > > the structure of the documents so the recommended macros go first > > and the behind-the-scenes boilerplate last. > > I agree 100%, and maybe I will give it a try later. > > My immediate goal was to just remove the examples in the docs > where type checking macros were defined manually. Since we > introduced the new QOM helper macros, the number of OBJECT_CHECK > macros in the QEMU tree almost doubled (from 40 in commit > 8110fa1d94f2 to 75 in commit bccabb3a5d60). Yeah, to be clear, I'm all in favour of changes like this patchset and don't think we should hold them up because we have a theoretical larger restructuring of the documentation we might one day (or never) get round to. -- PMM
