Hi Philippe,
Op wo 23 jun. 2021 20:00 schreef Philippe Mathieu-Daudé <f4...@amsat.org>:
> U-Boot expects the SD card size to be at least 2GiB, so
> expand the SD card image to this size before using it.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
> TODO: U-Boot reference?
> ---
> tests/acceptance/boot_linux_console.py | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index b10f7257503..c4c0f0b393d 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -820,11 +820,13 @@ def test_arm_orangepi_bionic_20_08(self):
> :avocado: tags=arch:arm
> :avocado: tags=machine:orangepi-pc
> :avocado: tags=device:sd
> + :avocado: tags=u-boot
> """
>
> - # This test download a 275 MiB compressed image and expand it
> - # to 1036 MiB, but the underlying filesystem is 1552 MiB...
> - # As we expand it to 2 GiB we are safe.
> + # This test download a 275 MiB compressed image and inflate it
>
Only a few typos here:
download -> downloads
inflate -> inflates
Otherwise, looks fine:
Reviewed-by: Niek Linnenbank <nieklinnenb...@gmail.com>
+ # to 1036 MiB, but 1/ the underlying filesystem is 1552 MiB,
> + # 2/ U-Boot loads TFTP filenames from the last sector below
> + # 2 GiB, so we need to expand the image further more to 2 GiB.
>
> image_url = ('https://archive.armbian.com/orangepipc/archive/'
>
> 'Armbian_20.08.1_Orangepipc_bionic_current_5.8.5.img.xz')
> @@ -833,7 +835,7 @@ def test_arm_orangepi_bionic_20_08(self):
> image_path_xz = self.fetch_asset(image_url, asset_hash=image_hash,
> algorithm='sha256')
> image_path = archive.extract(image_path_xz, self.workdir)
> - image_pow2ceil_expand(image_path)
> + image_expand(image_path, 2 * 1024 * 1024 * 1024)
>
> self.vm.set_console()
> self.vm.add_args('-drive', 'file=' + image_path +
> ',if=sd,format=raw',
> --
> 2.31.1
>
>
